Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to reproduce error 41 #973

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vmaurin
Copy link
Contributor

@vmaurin vmaurin commented Jan 30, 2024

Changes

The goal of this branch is to reproduce an error of not sending the create/delete topics command to the controller, and getting an error code 41, to then fix it in the admin client, as proposed in #865

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (e8383ea) 95.04% compared to head (cc60fbe) 94.95%.
Report is 3 commits behind head on master.

Files Patch % Lines
tests/manual/topic_management.py 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
- Coverage   95.04%   94.95%   -0.09%     
==========================================
  Files         107      108       +1     
  Lines       16408    16426      +18     
  Branches     2624     2626       +2     
==========================================
+ Hits        15595    15598       +3     
- Misses        536      552      +16     
+ Partials      277      276       -1     
Flag Coverage Δ
cext 91.67% <0.00%> (-0.09%) ⬇️
integration 94.60% <0.00%> (-0.09%) ⬇️
purepy 94.39% <0.00%> (-0.12%) ⬇️
unit 44.85% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant