add typing to aiokafka/coordinator/* #1006
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ods
reviewed
May 7, 2024
| @@ -37,8 +51,9 @@ def metadata(self, topics): | |||
| MemberMetadata struct | |||
| """ | |||
|
|
|||
| @classmethod | |||
There was a problem hiding this comment.
(offtopic) Why is it class method? It's strange to have a shared state among all clients
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1006 +/- ##
===========================================
- Coverage 95.04% 52.94% -42.11%
===========================================
Files 114 114
Lines 16906 16970 +64
Branches 2759 2771 +12
===========================================
- Hits 16068 8984 -7084
- Misses 493 7677 +7184
+ Partials 345 309 -36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ods
reviewed
May 20, 2024
| @@ -548,7 +552,8 @@ def _perform_reassignments( | |||
| ) | |||
|
|
|||
| if ( | |||
| partition in self.previous_assignment | |||
| consumer is not None | |||
There was a problem hiding this comment.
Why this change here and below is needed?
| topics: Set[str], | ||
| topics_partitions: Optional[Set[int]] = None, | ||
| topic_partitions_lambda: Optional[Callable[[str], Optional[Set[int]]]] = None, | ||
| ) -> MagicMock: |
There was a problem hiding this comment.
Shouldn't we declare mocked type instead? Not sure whether this is correct though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.