Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typing to tests/test_protocol* #1005

Merged
merged 4 commits into from
May 15, 2024

Conversation

dimastbk
Copy link
Contributor

@dimastbk dimastbk commented May 6, 2024

Changes

Fixes #

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (c759664) to head (390072f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1005      +/-   ##
==========================================
- Coverage   95.04%   95.00%   -0.04%     
==========================================
  Files         114      114              
  Lines       16917    16905      -12     
  Branches     2757     2758       +1     
==========================================
- Hits        16079    16061      -18     
- Misses        493      497       +4     
- Partials      345      347       +2     
Flag Coverage Δ
cext 91.90% <100.00%> (-0.06%) ⬇️
integration 94.65% <100.00%> (-0.04%) ⬇️
purepy 94.46% <100.00%> (-0.06%) ⬇️
unit 52.73% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/test_protocol.py Outdated Show resolved Hide resolved
tests/test_protocol.py Outdated Show resolved Hide resolved
tests/test_protocol_object_conversion.py Outdated Show resolved Hide resolved
@ods ods merged commit f9edd9e into aio-libs:master May 15, 2024
30 of 31 checks passed
@dimastbk dimastbk deleted the add-typing-to-test-protocol branch May 15, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants