Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8408/17c39719 backport][3.10] Remove use of typing.ByteString #8409

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented May 10, 2024

This is a backport of PR #8408 as merged into master (17c3971).

What do these changes do?

This PR removes use of typing.ByteString from aiohttp. ByteString has been deprecated since Python 3.12, and has already been removed on the CPython main branch (though that change will not be released until Python 3.14 comes out). That means that aiohttp currently installs, but fails to be imported, on Python 3.14:

    import aiohttp
env/lib/python3.14/site-packages/aiohttp/__init__.py:6: in <module>
    from .client import (
env/lib/python3.14/site-packages/aiohttp/client.py:38: in <module>
    from . import hdrs, http, payload
env/lib/python3.14/site-packages/aiohttp/payload.py:10: in <module>
    from typing import (
E   ImportError: cannot import name 'ByteString' from 'typing' (/Users/alexw/dev/cpython/Lib/typing.py)

Are there changes in behavior for the user?

The user will now be able to import aiohttp using Python 3.14+

Is it a substantial burden for the maintainers to support this?

no

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@patchback patchback bot requested a review from asvetlov as a code owner May 10, 2024 22:42
@patchback patchback bot mentioned this pull request May 10, 2024
5 tasks
@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) May 10, 2024 22:42
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.45%. Comparing base (e839279) to head (9a5d2a6).
Report is 2 commits behind head on 3.10.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #8409      +/-   ##
==========================================
- Coverage   97.51%   97.45%   -0.07%     
==========================================
  Files         108      108              
  Lines       33285    33285              
  Branches     3997     3997              
==========================================
- Hits        32459    32437      -22     
- Misses        602      620      +18     
- Partials      224      228       +4     
Flag Coverage Δ
CI-GHA 97.37% <100.00%> (-0.06%) ⬇️
OS-Linux 97.04% <100.00%> (-0.06%) ⬇️
OS-Windows 94.70% <100.00%> (ø)
OS-macOS 96.77% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.87% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 96.84% <100.00%> (ø)
Py-3.11.9 97.07% <100.00%> (ø)
Py-3.12.3 97.18% <100.00%> (ø)
Py-3.8.10 94.44% <100.00%> (ø)
Py-3.8.18 96.73% <100.00%> (ø)
Py-3.9.13 96.87% <100.00%> (ø)
Py-3.9.19 96.84% <100.00%> (ø)
Py-pypy7.3.15 ?
VM-macos 96.77% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.04% <100.00%> (-0.06%) ⬇️
VM-windows 94.70% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 64f02b1 into 3.10 May 10, 2024
31 of 34 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.10/17c39719a45a4a75550bb2c619f73ef0bb28dbe3/pr-8408 branch May 10, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants