Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat Accept-Encoding header as case-insensitive for gzip file check #8127

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

steverep
Copy link
Contributor

@steverep steverep commented Feb 1, 2024

What do these changes do?

Fixes issue in in server file response which does not convert Accept-Encoding header to lowercase before comparison.

Are there changes in behavior for the user?

No

Is it a substantial burden for the maintainers to support this?

No

Related issue number

Fixes 1st task of #8104

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Feb 1, 2024
@bdraco bdraco added backport-3.9 Trigger automatic backporting to the 3.9 release branch by Patchback robot backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot labels Feb 1, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b33fe6) 97.41% compared to head (16ba1e1) 97.41%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8127   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files         107      107           
  Lines       32732    32732           
  Branches     3823     3823           
=======================================
  Hits        31885    31885           
  Misses        640      640           
  Partials      207      207           
Flag Coverage Δ
CI-GHA 97.32% <100.00%> (ø)
OS-Linux 96.99% <100.00%> (ø)
OS-Windows 95.50% <100.00%> (ø)
OS-macOS 96.82% <100.00%> (ø)
Py-3.10.11 95.43% <100.00%> (ø)
Py-3.10.13 96.80% <100.00%> (-0.01%) ⬇️
Py-3.11.7 96.49% <100.00%> (ø)
Py-3.12.1 96.62% <100.00%> (ø)
Py-3.8.10 95.40% <100.00%> (ø)
Py-3.8.18 96.74% <100.00%> (ø)
Py-3.9.13 95.40% <100.00%> (ø)
Py-3.9.18 96.78% <100.00%> (ø)
Py-pypy7.3.15 96.33% <100.00%> (-0.01%) ⬇️
VM-macos 96.82% <100.00%> (ø)
VM-ubuntu 96.99% <100.00%> (ø)
VM-windows 95.50% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steverep

@bdraco bdraco merged commit b97d9a9 into aio-libs:master Feb 2, 2024
32 of 34 checks passed
Copy link
Contributor

patchback bot commented Feb 2, 2024

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/b97d9a97b239e33bc3f8df321defa853864a639e/pr-8127

Backported as #8130

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Feb 2, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/b97d9a97b239e33bc3f8df321defa853864a639e/pr-8127

Backported as #8131

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 2, 2024
@steverep steverep deleted the fix-case-sensitive-accept-encoding branch February 2, 2024 19:08
bdraco pushed a commit that referenced this pull request Feb 2, 2024
…se-insensitive for gzip file check (#8131)

Co-authored-by: Steve Repsher <steverep@users.noreply.github.com>

This is a backport of PR #8127 as merged into master (b97d9a9).
bdraco pushed a commit that referenced this pull request Feb 2, 2024
…e-insensitive for gzip file check (#8130)

Co-authored-by: Steve Repsher <steverep@users.noreply.github.com>

This is a backport of PR #8127 as merged into master (b97d9a9).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.9 Trigger automatic backporting to the 3.9 release branch by Patchback robot backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants