Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8-no-implicit-concat #7731

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

booniepepper
Copy link

@booniepepper booniepepper commented Oct 18, 2023

What do these changes do?

This will forbid weird implicit string concatenations.

https://pypi.org/project/flake8-no-implicit-concat/

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@booniepepper
Copy link
Author

booniepepper commented Oct 18, 2023

(While a draft: Expecting the first attempt to fail, I'll update accordingly when I can make the time)

@webknjaz
Copy link
Member

May I ask you to keep the deps sorted alphabetically?

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@Dreamsorcerer
Copy link
Member

(While a draft: Expecting the first attempt to fail, I'll update accordingly when I can make the time)

Think you need to enable the codes in the flake8 config. Probably just NIC001 and NIC101 (I'm not sure I want to disallow multi-line concatenations).

@webknjaz
Copy link
Member

webknjaz commented Nov 3, 2023

I'm not sure I want to disallow multi-line concatenations

I'd like to keep multiline implicit concat allowed.

setup.cfg Outdated Show resolved Hide resolved
@webknjaz webknjaz added enhancement infra backport-3.9 Trigger automatic backporting to the 3.9 release branch by Patchback robot backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot labels Jan 29, 2024
@webknjaz
Copy link
Member

@booniepepper this will need a changelog fragment of the contrib type: https://docs.aiohttp.org/en/stable/contributing.html#adding-change-notes-with-your-prs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.9 Trigger automatic backporting to the 3.9 release branch by Patchback robot backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot enhancement infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants