Add runner.serve_forever() #7688
Open
+62
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7688 +/- ##
========================================
Coverage 97.36% 97.36%
========================================
Files 106 106
Lines 31541 31661 +120
Branches 3593 3625 +32
========================================
+ Hits 30709 30826 +117
- Misses 630 631 +1
- Partials 202 204 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Sorry for taking so long to look at this. I have a few questions about the implementation and expected behaviour:
|
| :async: | ||
|
|
||
| Wait forever. Make sure to call :meth:`setup` prior calling this method. | ||
| Only one :meth:`serve_forever` task is allowed per one runner object. |
There was a problem hiding this comment.
Suggested change
| Only one :meth:`serve_forever` task is allowed per one runner object. | |
| Only one :meth:`serve_forever` task is allowed per runner object. |
| runner = make_runner() | ||
| task = loop.create_task(runner.serve_forever()) | ||
| await asyncio.sleep(0.01) | ||
| with pytest.raises(RuntimeError): |
There was a problem hiding this comment.
Can we use the match argument to match the text of the exception in these?
The codecov comment suggests this test isn't working correctly.
Dreamsorcerer
added
the
backport-3.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This is a continuation of work from #4378. I've dropped
cleanupcall onserve_forever()task cancellationand updated the documentation accordingly.
Are there changes in behavior for the user?
No.
Related issue number
#2746
Original attempt from asvetlov: master...server_forever
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.