Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][3.9] Make access log use local time with timezone #7557

Merged
merged 3 commits into from
Aug 26, 2023

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Aug 25, 2023

What do these changes do?

Backport #3860 to the 3.9 branch with the latest changes from master Use changelog fragment from #3860.
It was only ever merged into master and 3.8.

This also resolves a DeprecationWarning for Users when running Python 3.12 -> utcnow.

NewUserHa and others added 2 commits August 26, 2023 00:40
@cdce8p cdce8p requested a review from asvetlov as a code owner August 25, 2023 22:43
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #7557 (d335d3d) into 3.9 (b9b0906) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              3.9    #7557      +/-   ##
==========================================
- Coverage   97.31%   97.30%   -0.02%     
==========================================
  Files         107      107              
  Lines       31676    31679       +3     
  Branches     3665     3669       +4     
==========================================
- Hits        30825    30824       -1     
- Misses        646      651       +5     
+ Partials      205      204       -1     
Flag Coverage Δ
CI-GHA 97.25% <100.00%> (-0.02%) ⬇️
OS-Linux 96.93% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.45% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.61% <100.00%> (-0.02%) ⬇️
Py-3.10.11 94.36% <100.00%> (+<0.01%) ⬆️
Py-3.10.12 96.80% <100.00%> (-0.02%) ⬇️
Py-3.11.4 96.51% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.33% <100.00%> (+<0.01%) ⬆️
Py-3.8.17 96.74% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 94.34% <100.00%> (+<0.01%) ⬆️
Py-3.9.17 96.78% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.11 96.30% <46.66%> (+<0.01%) ⬆️
VM-macos 96.61% <100.00%> (-0.02%) ⬇️
VM-ubuntu 96.93% <100.00%> (+<0.01%) ⬆️
VM-windows 94.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aiohttp/web_log.py 100.00% <100.00%> (ø)
tests/test_web_log.py 98.27% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dreamsorcerer Dreamsorcerer merged commit 2ac5bbc into aio-libs:3.9 Aug 26, 2023
26 of 31 checks passed
@cdce8p cdce8p deleted the fix-utcnow branch August 26, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants