New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ClientResponse.certificate and populate it, if appropriate #7181
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7181 +/- ##
==========================================
- Coverage 97.31% 97.31% -0.01%
==========================================
Files 106 106
Lines 31260 31278 +18
Branches 3891 3893 +2
==========================================
+ Hits 30420 30437 +17
Misses 637 637
- Partials 203 204 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
85a6d61
to
f2ef428
Compare
The certificate must be populated before the EOF handler is assigned to avoid a race condition if the connection is closed quickly.
for more information, see https://pre-commit.ci
The linter failure in mypy is spurious. Should I silence this instance or is there a better way? |
mypy is pretty much deterministic, the failure will appear every time. |
Fixes #2816.
What do these changes do?
Add
ClientResponse.certificate
and populate it, if appropriate.Are there changes in behavior for the user?
Yes, the
ClientResponse.certificate
property contains the server certificate, if available.Related issue number
#2816
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.