Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6857/1e8c40fe backport][3.9] Stop installing cchardet speedup under >Python 3.9 #6861

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Aug 3, 2022

This is a backport of PR #6857 as merged into master (1e8c40f).

What do these changes do?

cchardet stopped being maintained a while ago so this patch removes
it from the speedups extra to keep it helpful. It also makes the
same adjustment in the CI under the most recent CPython versions to
keep the testing going.

Are there changes in behavior for the user?

pip install aiohttp[speedups] will only request cchardet under CPython < 3.10

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@webknjaz webknjaz merged commit 8bd1b93 into 3.9 Aug 3, 2022
@webknjaz webknjaz deleted the patchback/backports/3.9/1e8c40fe48245247f63549ebe119a6f309614889/pr-6857 branch August 3, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant