[PR #6727/adeece3c backport][3.8] Fix asyncio.CancelledError again (#6719)

[patchback]

This is a backport of PR #6727 as merged into master (adeece3).

asyncio.CancelledError() on peer disconnection have been removed by #4080,
but #4415 re-introduced it silently.

self._waiter.cancel() and self._task_handler.cancel() were added by #4415,
but #4415 in fact only needed self._waiter.cancel() (proof below).

So I propose to remove self._task_handler.cancel(), both #4080 and #4415 will
be fixed.

To test that I re-resolved #4080 I used:

async def handle(request):
    try:
        await asyncio.sleep(5)
        await request.text()
    except BaseException as e:
        print(f'base exception {type(e).__name__}')
    return web.Response(text='toto')

curl -X POST -H "Content-Type: text/plain" --data "bouh" localhost:8080

I kill the curl request before the 5 seconds of sleep.
Before this PR I have the following error right after killing the curl:

$ python -Wall -X dev test.py
======== Running on http://0.0.0.0:8080 ========
(Press CTRL+C to quit)
base exception CancelledError

After this commit I have the following error, but only after the 5 seconds
sleep:

$ python -Wall -X dev test.py
======== Running on http://0.0.0.0:8080 ========
(Press CTRL+C to quit)
base exception ConnectionResetError

To test that I didn't re-introduce #4415 I use a basic handle and 30
curl localhost:8080:

• Before this commit no issue

• If I remove self._task_handler.cancel() no issue

• If I remove both self._task_handler.cancel() and self._waiter.cancel():

  $ python -Wall -X dev test.py
  ======== Running on http://0.0.0.0:8080 ========
  (Press CTRL+C to quit)
  Task was destroyed but it is pending!
  task: <Task pending name='Task-4' coro=<RequestHandler.start() done, defined at ...
  Task was destroyed but it is pending!
  ...

So it's OK to remove only self._task_handler.cancel().

There is no documentation or tests to be updated because #4080 already did that
part.

However I guess that for a few people it might be seen as a breaking change,
I'm not sure.

Tested on master and on v3.8.1.

fixes #6719

[H--o-l]

@Dreamsorcerer Thanks for the review and merge! A release of aiohttp v3.8.2 with this change would be useful for me in production, do you have an expected release date for aiohttp v3.8.2?

[Dreamsorcerer]

I've never done a release for aiohttp before, so I'm hoping someone else will come back to it. If they're still away in a while, then I'll try and figure out a 3.8 release.

[H--o-l]

Hi @Dreamsorcerer!

It's been a month since the merge of this PR, maybe a new release could be considered?

(Sorry to bother you with that, thanks again for your help on the subject)

[H--o-l]

Hi, @Dreamsorcerer @asvetlov!

Sorry to bother you, but can you tell me if there is still no new released planned in the coming weeks?