Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6163/a0a9b3db backport][3.9] Add clarification to configuring app #6342

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 23, 2021

This is a backport of PR #6163 as merged into master (a0a9b3d).

What do these changes do?

Added clarification on configuring the app object with setings such as a db connection

Are there changes in behavior for the user?

No

Related issue number

Closes #4137

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
(cherry picked from commit a0a9b3d)
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (3.9@a089aa4). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head a0a9b3d differs from pull request most recent head c9950d9. Consider uploading reports for the commit c9950d9 to get more accurate results
Impacted file tree graph

@@          Coverage Diff           @@
##             3.9    #6342   +/-   ##
======================================
  Coverage       ?   93.32%           
======================================
  Files          ?      103           
  Lines          ?    30368           
  Branches       ?     2730           
======================================
  Hits           ?    28341           
  Misses         ?     1850           
  Partials       ?      177           
Flag Coverage Δ
unit 93.24% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a089aa4...c9950d9. Read the comment docs.

@asvetlov asvetlov merged commit d17fb4a into 3.9 Dec 4, 2021
@asvetlov asvetlov deleted the patchback/backports/3.9/a0a9b3db486df1ea2aed21dc6c9c1d72452d31fc/pr-6163 branch December 4, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants