Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6313/d149eff6 backport][3.8] docs: Fix statement about setUpAsync() and tearDownAsync() #6317

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 16, 2021

This is a backport of PR #6313 as merged into master (d149eff).

Since #4732, it's wrong to says that
setUpAsync() and tearDownAsync() do nothing and can be overridden without
calling super.setUpAsync() and super.tearDownAsync().

What do these changes do?

Fix documentation

Are there changes in behavior for the user?

No

Related issue number

None

Checklist

Only docs.


Remark:
My rst preview wasn't working, I hope there is no rst mistakes.

Since #4732, it's wrong to says that
`setUpAsync()` and `tearDownAsync()` do nothing and can be overridden without
calling `super.setUpAsync()` and `super.tearDownAsync()`.

(cherry picked from commit d149eff)
@asvetlov asvetlov enabled auto-merge (squash) November 16, 2021 14:16
@asvetlov asvetlov merged commit 724a996 into 3.8 Nov 16, 2021
@asvetlov asvetlov deleted the patchback/backports/3.8/d149eff62e1e110d2eafac8a79219dd2e56b8581/pr-6313 branch November 16, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants