Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6189/fe792950 backport][3.9] Fix setup.cfg not to install "examples" top-level package #6192

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 1, 2021

This is a backport of PR #6189 as merged into master (fe79295).

What do these changes do?

They fix setup.cfg to not to install examples as top-level packages.

Are there changes in behavior for the user?

No.

Related issue number

n/a

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

❗ No coverage uploaded for pull request base (3.9@c61395f). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head fe79295 differs from pull request most recent head 0b2ed48. Consider uploading reports for the commit 0b2ed48 to get more accurate results
Impacted file tree graph

@@          Coverage Diff           @@
##             3.9    #6192   +/-   ##
======================================
  Coverage       ?   93.29%           
======================================
  Files          ?      102           
  Lines          ?    30351           
  Branches       ?     2729           
======================================
  Hits           ?    28315           
  Misses         ?     1858           
  Partials       ?      178           
Flag Coverage Δ
unit 93.21% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c61395f...0b2ed48. Read the comment docs.

@asvetlov asvetlov merged commit ea5c8f9 into 3.9 Nov 1, 2021
@asvetlov asvetlov deleted the patchback/backports/3.9/fe792950fcb8d30fbf96c778da3253659bfa8935/pr-6189 branch November 1, 2021 13:08
@webknjaz
Copy link
Member

webknjaz commented Nov 1, 2021

@asvetlov looks like we need to delete that backporting action because it just duplicates the bot for no reason...

@asvetlov
Copy link
Member

asvetlov commented Nov 1, 2021

done already today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants