Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #4661/50753eac backport][3.8] Support websocket proxies configured via environment variables #6183

Conversation

webknjaz
Copy link
Member

This is a backport of PR #4661 as merged into master (50753ea).

PR #4661

Resolves #4648

Co-authored-by: Sviatoslav Sydorenko wk.cvs.github@sydorenko.org.ua
(cherry picked from commit 50753ea)

What do these changes do?

Fixes a problem with the non-working configuration of the proxy
for wss (when a proxy URL was set via env var).

Are there changes in behavior for the user?

Working proxy

Related issue number

Resolves #4648

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 31, 2021
PR aio-libs#4661

Resolves aio-libs#4648

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
(cherry picked from commit 50753ea)
@webknjaz webknjaz force-pushed the patchback/backports/3.8/50753eace15da24a9fb9774bcfcaa1dc7650164e/pr-4661 branch from 8780f60 to 6de13a1 Compare October 31, 2021 19:01
@webknjaz webknjaz merged commit a4b70ab into aio-libs:3.8 Oct 31, 2021
@webknjaz webknjaz deleted the patchback/backports/3.8/50753eace15da24a9fb9774bcfcaa1dc7650164e/pr-4661 branch October 31, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants