Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #5452/a1158c53 backport][3.8] Add validation of HTTP status line, header keys and values #5984

Merged
merged 2 commits into from
Sep 4, 2021
Merged

[PR #5452/a1158c53 backport][3.8] Add validation of HTTP status line, header keys and values #5984

merged 2 commits into from
Sep 4, 2021

Commits on Sep 4, 2021

  1. Add validation of HTTP status line, header keys and values (#5452) 

    * Add validation of HTTP status line, header keys and values

* Apply review comments

* Rename _check_string to _safe_header and remove validation for the status_line

* Update aiohttp/http_writer.py

Co-authored-by: Sam Bull <aa6bs0@sambull.org>

* Modify changelog message

* Refactor headers join

* Refactor headers serialization back to the broken down version and add the second CRLF sign after the headers

* Update aiohttp/http_writer.py

Co-authored-by: Sam Bull <aa6bs0@sambull.org>
(cherry picked from commit a1158c5)
    @franekmagiera
    franekmagiera authored and Patchback committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    d1195a9 View commit details
    Browse the repository at this point in the history

  2. Update test_http_writer.py

    @Dreamsorcerer
    Dreamsorcerer committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    bb19323 View commit details
    Browse the repository at this point in the history