New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if ipv6 is enabled, when processing socket address info #5906
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5906 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 44 44
Lines 9851 9854 +3
Branches 1591 1592 +1
=======================================
+ Hits 9531 9534 +3
Misses 182 182
Partials 138 138
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Is there any good way to test this change? It needs a CPython that compiled with |
CPython and enable ipv6 in system. Related to aio-libs#5901; `getaddrinfo` will return an `(int, bytes)` tuple, if CPython could not handle the address family. It will cause a index out of range error in aiohttp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I'm not really familiar with this part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 5ec6aec on top of patchback/backports/3.8/5ec6aec1baef1ff68d0bf3066b4f81f64c367376/pr-5906 Backporting merged PR #5906 into master
🤖 @patchback |
💔 Backport was not successfulThe PR was attempted backported to the following branches:
|
FTR this may have caused a regression, according to #6195. |
Thanks for the reminder! |
What do these changes do?
Related to #5901;
getaddrinfo
will return an(int, bytes)
tuple, ifCPython could not handle the address family. It will cause a index out
of range error in aiohttp.
Are there changes in behavior for the user?
I think not.
Related issue number
#5901 and #5156.
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.