StaticResource only matches folder-like URL prefix

CHANGES/5250.bugfix

@@ -0,0 +1 @@
+StaticResource prefixes no longer match URLs with a non-folder prefix. For example `routes.static('/foo', '/foo')` no longer matches the URL `/foobar`. Previously, this would attempt to load the file `/foo/ar`.

CONTRIBUTORS.txt

@@ -71,6 +71,7 @@ Claudiu Popa
 Colin Dunklau
 Cong Xu
 Damien Nadé
+Dan King
 Dan Xu
 Daniel García
 Daniel Grossmann-Kavanagh

aiohttp/web_urldispatcher.py

@@ -617,7 +617,7 @@ async def resolve(self, request: Request) -> _Resolve:
         path = request.rel_url.raw_path
         method = request.method
         allowed_methods = set(self._routes)
-        if not path.startswith(self._prefix):
+        if not path.startswith(self._prefix + "/") and path != self._prefix:
             return None, set()
 
         if method not in allowed_methods:

tests/test_web_urldispatcher.py

@@ -458,3 +458,18 @@ async def test_static_absolute_url(aiohttp_client: Any, tmp_path: Any) -> None:
     client = await aiohttp_client(app)
     resp = await client.get("/static/" + str(file_path.resolve()))
     assert resp.status == 403
+
+
+async def test_for_issue_5250(aiohttp_client: Any, tmp_path: Any) -> None:
+    app = web.Application()
+    app.router.add_static("/foo", tmp_path)
+
+    async def get_foobar(request):
+        return web.Response(body="success!")
+
+    app.router.add_get("/foobar", get_foobar)
+
+    client = await aiohttp_client(app)
+    async with await client.get("/foobar") as resp:
+        assert resp.status == 200
+        assert (await resp.text()) == "success!"