Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added final declarations to constants (#5275) #5310

Merged
merged 14 commits into from Dec 17, 2020
Merged

Added final declarations to constants (#5275) #5310

merged 14 commits into from Dec 17, 2020

Conversation

WisdomPill
Copy link
Member

@WisdomPill WisdomPill commented Dec 5, 2020 •
edited

What do these changes do?

Adds final declarations to constants

Are there changes in behavior for the user?

Let the user know that these constants should be considered as immutable

Related issue number

#5275

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 5, 2020
@WisdomPill
Copy link
Member Author

WisdomPill commented Dec 5, 2020 •
edited

@asvetlov Final has been introduced since python 3.8, what to do then?

asvetlov
asvetlov requested changes Dec 6, 2020
View reviewed changes
aiohttp/client.py Outdated Show resolved Hide resolved
aiohttp/client_ws.py Outdated Show resolved Hide resolved
aiohttp/hdrs.py Outdated Show resolved Hide resolved
aiohttp/http_parser.py Outdated Show resolved Hide resolved
aiohttp/http_websocket.py Outdated Show resolved Hide resolved
aiohttp/payload.py Show resolved Hide resolved
aiohttp/web_fileresponse.py Outdated Show resolved Hide resolved
aiohttp/web_request.py Outdated Show resolved Hide resolved
aiohttp/web_urldispatcher.py Outdated Show resolved Hide resolved
aiohttp/web_ws.py Outdated Show resolved Hide resolved
@WisdomPill
Copy link
Member Author

@asvetlov can you guide on the cython error that comes up now?

@WisdomPill
Copy link
Member Author

@asvetlov friendly reminder, I get an error in cythonize, I do not know how to solve it

@asvetlov
Copy link
Member

To make CI passed please add the following line to requirements/cython.txt:

typing_extensions==3.7.4.3  # required for parsing aiohttp/hdrs.py by tools/gen.py

@codecov
Copy link

codecov bot commented Dec 17, 2020 •
edited

Codecov Report

Merging #5310 (7ecdf50) into master (cb4bae7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5310   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          41       41           
  Lines        8739     8746    +7     
  Branches     1402     1402           
=======================================
+ Hits         8491     8498    +7     
  Misses        129      129           
  Partials      119      119
Flag Coverage Δ
unit 97.05% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/client_proto.py 96.66% <ø> (ø)
aiohttp/formdata.py 98.92% <ø> (ø)
aiohttp/streams.py 97.45% <ø> (ø)
aiohttp/web.py 99.14% <ø> (ø)
aiohttp/web_middlewares.py 100.00% <ø> (ø)
aiohttp/web_server.py 94.28% <ø> (ø)
aiohttp/hdrs.py 100.00% <100.00%> (ø)
aiohttp/http_parser.py 97.15% <100.00%> (+<0.01%) ⬆️
aiohttp/http_websocket.py 98.65% <100.00%> (+<0.01%) ⬆️
aiohttp/payload.py 95.37% <100.00%> (+0.02%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0ed732...7ecdf50. Read the comment docs.

@asvetlov asvetlov enabled auto-merge (squash) December 17, 2020 10:48
@asvetlov asvetlov merged commit 3be8a68 into aio-libs:master Dec 17, 2020
@aio-libs-github-bot
Copy link
Contributor

💔 Backport was not successful

The PR was attempted backported to the following branches:

  • ❌ 3.8: Commit could not be cherrypicked due to conflicts

asvetlov pushed a commit that referenced this pull request Dec 17, 2020
@WisdomPill @asvetlov
[3.8] Added final declarations to constants (#5275) (#5310)
f51cdfa 
Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>.
(cherry picked from commit 3be8a68)

Co-authored-by: Anas <anas.el.amraoui@live.com>
@asvetlov
Copy link
Member

Thanks!

asvetlov added a commit that referenced this pull request Dec 17, 2020
@asvetlov @WisdomPill
[3.8] Added final declarations to constants (#5275) (#5310) (#5354)
505b8f3 
Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>.
(cherry picked from commit 3be8a68)

Co-authored-by: Anas <anas.el.amraoui@live.com>
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
@WisdomPill @asvetlov @commonism
Added final declarations to constants (aio-libs#5275) (aio-libs#5310)
bffa543 
Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
@WisdomPill @asvetlov @commonism
Added final declarations to constants (aio-libs#5275) (aio-libs#5310)
e9f17c8 
Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WisdomPill @asvetlov