Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keepalive_timeout parameter to web.run_app #5095

Merged
merged 16 commits into from
Oct 27, 2020
Merged

Add keepalive_timeout parameter to web.run_app #5095

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c8ccce0
Add keepalive_timeout parameter to web.run_app
janbuchar Oct 20, 2020
fcc2253
Add test for setting keepalive_timeout
janbuchar Oct 20, 2020
827375f
Code format
janbuchar Oct 20, 2020
2a99b5c
A more complex way to spy on BaseRunner.__init__
janbuchar Oct 20, 2020
df61102
Update doc
janbuchar Oct 20, 2020
dfa3639
Update CONTRIBUTORS.txt
janbuchar Oct 20, 2020
427489c
Add missing full stop
janbuchar Oct 20, 2020
7a84d8d
Merge branch 'master' into master
janbuchar Oct 20, 2020
fcc6de6
Fix call_args usage for Python < 3.8
janbuchar Oct 20, 2020
998fb71
Update tests/test_run_app.py
janbuchar Oct 20, 2020
f136cd9
Simplify test
janbuchar Oct 26, 2020
2a33550
Update docs/web_reference.rst
janbuchar Oct 26, 2020
4ecfaf8
Change versionadded for the keepalive_timeout parameter
janbuchar Oct 27, 2020
ccefa65
Fix code style
janbuchar Oct 27, 2020
beee1d5
Merge branch 'master' into master
janbuchar Oct 27, 2020
4dda278
Apply suggestions from code review
janbuchar Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/web_reference.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2798,6 +2798,8 @@ Utilities
closed after a HTTP request. The delay
allows for reuse of a TCP connection.

janbuchar marked this conversation as resolved.
Show resolved Hide resolved
.. versionadded:: 3.7
Copy link
Member

@asvetlov asvetlov Oct 26, 2020 •
edited by webknjaz

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. versionadded:: 3.7
.. versionadded:: 3.8

Sorry, the time window for 3.1 is closed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood.


:param ssl_context: :class:`ssl.SSLContext` for HTTPS server,
``None`` for HTTP connection.

Expand Down