Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for using patch decorator in unittest prior to python 3.8 #4697

Merged
merged 10 commits into from
Apr 20, 2020

Conversation

WisdomPill
Copy link
Member

What do these changes do?

As discussed in #4695 patch and make_mocked_coro do not work in a decorated unittest test case. So in the docs it is advised to use a package called asynctest for async method patching.

Are there changes in behavior for the user?

It is described in the docs.

Related issue number

#4695

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 18, 2020
docs/testing.rst Outdated Show resolved Hide resolved
docs/testing.rst Outdated Show resolved Hide resolved
docs/testing.rst Outdated Show resolved Hide resolved
WisdomPill and others added 2 commits April 20, 2020 19:36
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
@codecov-io

This comment has been minimized.

docs/testing.rst Outdated Show resolved Hide resolved
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
docs/testing.rst Outdated Show resolved Hide resolved
docs/testing.rst Outdated Show resolved Hide resolved
WisdomPill and others added 2 commits April 20, 2020 21:50
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
@webknjaz webknjaz changed the title Docs for using patch as a decorator in unittest below python 3.8 Add docs for using patch decorator in unittest prior to python 3.8 Apr 20, 2020
@webknjaz webknjaz merged commit e583a4b into aio-libs:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants