-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make access log use local time with timezone #3860
Merged
Merged
Changes from 21 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
6cb6c16
Update web_log.py
NewUserHa 70dfff5
Update web_log.py
NewUserHa 7c799d6
Update web_log.py
NewUserHa 07cf978
Update test_web_log.py
NewUserHa 32bda21
Update aiohttp/web_log.py
NewUserHa 59be3d8
Update web_log.py
NewUserHa aca2aa0
Update test_web_log.py
NewUserHa 5487e55
Update test_web_log.py
NewUserHa da3ff3c
Update tests/test_web_log.py
NewUserHa 043963e
Update tests/test_web_log.py
NewUserHa 935543f
Update test_web_log.py
NewUserHa 5c6bf7b
Update test_web_log.py
NewUserHa f29509b
Update test_web_log.py
NewUserHa 3487247
Update test_web_log.py
NewUserHa 1947585
Update test_web_log.py
NewUserHa d2dda4c
Update test_web_log.py
NewUserHa 2845c29
Update web_log.py
NewUserHa 24a6fe5
Update test_web_log.py
NewUserHa 2d66fcd
Update test_web_log.py
NewUserHa 7cb706c
Update test_web_log.py
NewUserHa e5aef98
Update test_web_log.py
NewUserHa 9a2e802
Update test_web_log.py
NewUserHa f6b5f3e
Update test_web_log.py
NewUserHa e051d27
Update test_web_log.py
NewUserHa 3aa1cc8
Update test_web_log.py
NewUserHa c5f66e6
Update test_web_log.py
NewUserHa File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure that skip marker doesn't work on fixtures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but if use parameterizing, it seems to have to use fixtrue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I'm talking about that the marked is supposed to skip things depending on the condition (PyPy). And if you apply it to fixtures, not test functions it just doesn't have any effect meaning it will never skip any tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. I need to check some documents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, it's okay since you removed the fixture.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but...