Skip to content

Commit

Permalink
adjust according to PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
derlih committed Oct 27, 2021
1 parent 7dc0bce commit e9dd0f0
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions tests/test_client_session.py
Expand Up @@ -709,7 +709,7 @@ async def test_requote_redirect_url_default_disable() -> None:


@pytest.mark.parametrize(
"base_url,url",
("base_url", "url"),
[
(None, "http://example.com/test"),
("http://example.com", "/test"),
Expand All @@ -718,20 +718,20 @@ async def test_requote_redirect_url_default_disable() -> None:
(URL("http://example.com/"), "/test"),
],
)
async def test_build_url(base_url, url) -> None:
session = ClientSession(base_url)
async def test_build_url(create_session, base_url, url) -> None:
session = await create_session(base_url)
assert session._build_url(url) == URL("http://example.com/test")


async def test_build_url_raises() -> None:
session = ClientSession("http://example.com")
async def test_build_url_raises(create_session) -> None:
session = await create_session("http://example.com")
with pytest.raises(ValueError):
session._build_url("test")


async def test_request_uses_base_url_when_url_is_str() -> None:
async def test_request_uses_base_url_when_url_is_str(create_session) -> None:
request_class = mock.MagicMock()
session = ClientSession("http://example.com", request_class=request_class)
session = await create_session("http://example.com", request_class=request_class)
with contextlib.suppress(Exception):
await session.get("/test")

Expand All @@ -740,9 +740,9 @@ async def test_request_uses_base_url_when_url_is_str() -> None:
assert url == URL("http://example.com/test")


async def test_request_not_uses_base_url_when_url_is_URL() -> None:
async def test_request_not_uses_base_url_when_url_is_URL(create_session) -> None:
request_class = mock.MagicMock()
session = ClientSession("http://example.com", request_class=request_class)
session = await create_session("http://example.com", request_class=request_class)
with contextlib.suppress(Exception):
await session.get(URL("http://sample.com"))

Expand Down

0 comments on commit e9dd0f0

Please sign in to comment.