Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Remove __del__ from Redis (Fixes #1115) #1227

Merged
merged 6 commits into from Dec 16, 2021
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/1227.bugfix
@@ -0,0 +1 @@
Delete `__del__` from Redis (Fixes #1115)
21 changes: 0 additions & 21 deletions aioredis/client.py
Expand Up @@ -1054,16 +1054,6 @@ async def __aenter__(self: _RedisT) -> _RedisT:
async def __aexit__(self, exc_type, exc_value, traceback):
await self.close()

def __del__(self):
try:
loop = asyncio.get_event_loop()
if loop.is_running():
loop.create_task(self.close())
else:
loop.run_until_complete(self.close())
except Exception:
pass

async def close(self):
conn = self.connection
if conn:
Expand Down Expand Up @@ -4349,17 +4339,6 @@ async def __aexit__(self, exc_type, exc_value, traceback):
def __await__(self):
return self._async_self().__await__()

def __del__(self):
try:
loop = asyncio.get_event_loop()
if loop.is_running():
loop.create_task(self.reset())
else:
loop.run_until_complete(self.reset())
super().__del__()
except Exception:
pass

def __len__(self):
return len(self.command_stack)

Expand Down