Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Add recommendation to install hiredis #1138

Closed
wants to merge 2 commits into from

Conversation

Andrew-Chen-Wang
Copy link
Collaborator

@Andrew-Chen-Wang Andrew-Chen-Wang commented Sep 23, 2021

What do these changes do?

Add docs about installing hiredis too since it is now an optional dependency.

Are there changes in behavior for the user?

Yes, installing hiredis is a completely different parser.

Related issue number

#1137 points out how hiredis resolved for issue.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example:
      Fix issue with non-ascii contents in doctest text files.

View rendered README.md

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #1138 (4eebd3d) into master (4fbee2e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1138   +/-   ##
=======================================
  Coverage   89.23%   89.23%           
=======================================
  Files          21       21           
  Lines        6830     6830           
  Branches      654      654           
=======================================
  Hits         6095     6095           
  Misses        567      567           
  Partials      168      168           
Flag Coverage Δ
unit 89.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fbee2e...4eebd3d. Read the comment docs.

@Andrew-Chen-Wang
Copy link
Collaborator Author

Fixed in #1247

@Andrew-Chen-Wang Andrew-Chen-Wang deleted the hiredis-readme-docs branch December 24, 2021 03:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant