Enable mypy in CI (#1101)

* Enable mypy in CI
* Add change file.

* Lint

* Show diff in CI.

* Black

* Readd "unreachable" code.

* Fix typing for ConnectionError.

* Black

* Add client.py

* Fixes

* Black

* Imports

* Simplify cmds.

* Simplify cmds further.

* Give up

* Fix

* Rename to _Sentinel.

* Move self.encoder check.

* More precise type for auth_args.

.github/workflows/ci.yml

@@ -39,6 +39,10 @@ jobs:
       uses: py-actions/py-dependency-install@v2.1.0
       with:
         path: tests/requirements.txt
+    - name: Run mypy
+      run: |
+        pip install -r tests/requirements-mypy.txt
+        mypy
     - name: Run linter
       run: |
         make lint

.mypy.ini

@@ -0,0 +1,26 @@
+[mypy]
+#, docs/examples, tests
+files = aioredis
+check_untyped_defs = True
+follow_imports_for_stubs = True
+#disallow_any_decorated = True
+#disallow_any_generics = True
+#disallow_incomplete_defs = True
+disallow_subclassing_any = True
+#disallow_untyped_calls = True
+disallow_untyped_decorators = True
+#disallow_untyped_defs = True
+implicit_reexport = False
+no_implicit_optional = True
+show_error_codes = True
+strict_equality = True
+warn_incomplete_stub = True
+warn_redundant_casts = True
+warn_unreachable = True
+warn_unused_ignores = True
+disallow_any_unimported = True
+#warn_return_any = True
+
+[mypy-aioredis.lock]
+# TODO: Remove once locks has been rewritten
+ignore_errors = True

CHANGES/1101.misc

@@ -0,0 +1 @@
+Enable Mypy in CI.

Makefile

@@ -17,7 +17,7 @@ spelling:
 	$(MAKE) -C docs spelling
 
 mypy:
-	$(MYPY) aioredis --ignore-missing-imports
+	$(MYPY)
 
 test:
 	$(PYTEST)
@@ -38,7 +38,7 @@ init-hooks:
 	pre-commit install-hooks
 
 lint: init-hooks
-	pre-commit run --all-files
+	pre-commit run --all-files --show-diff-on-failure
 
 devel: aioredis.egg-info init-hooks
 	pip install -U pip