-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update example #60
update example #60
Conversation
@sphuber I don't know why the ci/tests failed, because the new changes will not affect the core code. I also run the test locally, all of them passed. |
hi @superstar54 , thanks for the fix! the test failures are indeed weird - either some of the data it's comparing against is coming from somewhere else or the mechanism of comparison may be flaky (perhaps dependent on order of query result / ...)?
If it's urgent, we can merge it as-is; otherwise let's wait until @sphuber has time to have a look |
Hi @ltalirz , thanks for looking into it. Not urgent, we can wait. |
Thanks @superstar54 . I will have a look at the CI soon and fix it. Then we can merge this. |
The examples were incorrectly using `GET` requests to start and stop the daemon, but this should be `POST` requests. The Quantum ESPRESSO example is also updated to use the SSSP family that is currently the default installed by `aiida-pseudo install sssp`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @superstar54 . I fixed a bunch of problems with the CI, so now all tests should pass again.
I run the scripts in the example folder. Two of them failed, and they need to be updated.
I got this error when committing new changes:
It's likely due the the
isort
package. I update its version to5.12.0
and there is no more error.