Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Try setup-python on arm runners #444

Closed
wants to merge 10 commits into from
Closed

WIP: Try setup-python on arm runners #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0ab6f3d
Try setup-python on arm runners
danielhollas Apr 17, 2024
7c6e7a4
Try v4
danielhollas Apr 17, 2024
ab82afa
4.3.0
danielhollas Apr 17, 2024
af109f2
4.0.0
danielhollas Apr 17, 2024
115a519
4.1.0
danielhollas Apr 17, 2024
f116f3c
Don't upload on failuer
danielhollas Apr 17, 2024
6412ce4
Don't use pip cache
danielhollas Apr 17, 2024
d9dc80f
Back to v5
danielhollas Apr 17, 2024
2e79d98
Add pip list
danielhollas Apr 17, 2024
bd5c869
Skip on arm for now
danielhollas Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 4 additions & 9 deletions .github/actions/create-dev-env/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,12 @@ inputs:
runs:
using: composite
steps:
# actions/setup-python doesn't support Linux arm64 runners
# See: https://github.com/actions/setup-python/issues/108
# python3 is manually preinstalled in the arm64 VM self-hosted runner
- name: Set Up Python 🐍
if: ${{ inputs.architecture == 'amd64' }}
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: 3.11

- name: Install Dev Dependencies 📦
run: |
pip install --upgrade pip
pip install --upgrade -r requirements-dev.txt
shell: bash
- name: Install dependencies 📦
run: pip list && pip install -r requirements-dev.txt
shell: bash -e {0}
2 changes: 0 additions & 2 deletions .github/workflows/docker-build-test-upload.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ jobs:
mkdir -p /tmp/aiidalab/
docker save ${{ env.OWNER }}/${{ inputs.image }} -o /tmp/aiidalab/${{ inputs.image }}-${{ inputs.architecture }}.tar
shell: bash
if: always()

- name: Upload image as artifact 💾
uses: actions/upload-artifact@v4
Expand All @@ -70,4 +69,3 @@ jobs:
path: /tmp/aiidalab/${{ inputs.image }}-${{ inputs.architecture }}.tar
retention-days: 3
if-no-files-found: error
if: always()
3 changes: 0 additions & 3 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ jobs:
needs: [arm64-base-with-services, arm64-lab]

amd64-push-ghcr:
if: always()
uses: ./.github/workflows/docker-push.yml
strategy:
matrix:
Expand All @@ -95,7 +94,6 @@ jobs:
needs: [amd64-base, amd64-base-with-services, amd64-lab, amd64-full-stack]

arm64-push-ghcr:
if: always()
uses: ./.github/workflows/docker-push.yml
strategy:
matrix:
Expand All @@ -110,7 +108,6 @@ jobs:
needs: [arm64-base, arm64-base-with-services, arm64-lab, arm64-full-stack]

merge-tags-ghcr:
if: always()
uses: ./.github/workflows/docker-merge-tags.yml
strategy:
matrix:
Expand Down