Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove constraints from GitHub in constraints.txt #2364

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Remove constraints from GitHub in constraints.txt #2364

merged 2 commits into from
Nov 6, 2023

Commits on Nov 6, 2023

  1. Remove constraints from GitHub in constraints.txt 

    In testing, it appears that unnamed constraints don't really have an effect on
what pip installs anyway, so they only seem to cause problems if included in
the constraints.txt file.

We retain dependencies from GitHub in requirements files passed to pip-compile,
as it can resolve dependencies of GitHub-based packages and use that to inform
the versions pinned.
    @spencerkclark
    spencerkclark committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    032649c View commit details
    Browse the repository at this point in the history

  2. Clarify comment in Makefile 

    Co-authored-by: Oliver Watt-Meyer <oliverwatt@gmail.com>
    @spencerkclark @oliverwm1
    spencerkclark and oliverwm1 committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    9fc3ead View commit details
    Browse the repository at this point in the history