Make unstacked_dims property default to ("z",) #2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcgibbon
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
There are still some long-standing confusing issues with the way the offline diags re-uses logic from the training for data, since what they need is fundamentally different (offline diags is specific to geospatial data, training is not). But this is practical and an improvement, so I'm in favor.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having to supply
unstacked_dims: - "z"to training and validation data configs, but not the test data config for offline diags is confusing for the user. This PR changes the default ofBatchesFromMapperConfig.unstacked_dimsto("z",)and modifies the offline diags routine to set this property toNone. A warning is printed if this change needs to be made.Refactored public API:
BatchesFromMapperConfig.unstacked_dimshas a default of("z",)instead ofNoneTests added
Coverage reports (updated automatically):