Skip to content

Commit

Permalink
Remove constraints from GitHub in constraints.txt
Browse files Browse the repository at this point in the history
In testing, it appears that unnamed constraints don't really have an effect on
what pip installs anyway, so they only seem to cause problems if included in
the constraints.txt file.

We retain dependencies from GitHub in requirements files passed to pip-compile,
as it can resolve dependencies of GitHub-based packages and use that to inform
the versions pinned.
  • Loading branch information
spencerkclark committed Nov 6, 2023
1 parent 314edd5 commit 032649c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,9 @@ constraints.txt: $(REQUIREMENTS)
.dataflow-versions.txt \
$^ \
--output-file constraints.txt
# remove constraints from GitHub, since pip does not support unnamed
# constraints, despite the fact that pip-compile includes them:
sed -i '/git+https/d' constraints.txt
# remove extras in name: e.g. apache-beam[gcp] --> apache-beam
sed -i.bak 's/\[.*\]//g' constraints.txt
rm -f constraints.txt.bak .dataflow-versions.txt
Expand Down
1 change: 0 additions & 1 deletion constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,6 @@ tf-estimator-nightly==2.8.0.dev2021122109
threadpoolctl==3.1.0
toml==0.10.1
toolz==0.10.0
git+https://github.com/NVIDIA/torch-harmonics.git@8826246cacf6c37b600cdd63fde210815ba238fd
torch==1.12.1
torchvision==0.13.1
tornado==6.1
Expand Down

0 comments on commit 032649c

Please sign in to comment.