Update IE polyfill to fix last improve with reduce #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai
reviewed
May 4, 2022
README.md
Outdated
|
|
||
| let size = array.length | ||
|
|
||
| while (size--) { |
There was a problem hiding this comment.
Can we use here for for better readability since this code is for users?
There was a problem hiding this comment.
Sure, updated to for loop
|
Yes, let's update it |
vitalybaev
force-pushed
the
fix-ie-polyfill
branch
from
45ffe14
to
e937875
Compare
|
Force pushed updates: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #355 improvement with reduce was introduced. However, it relies on the fact, that
UInt8Arrayis really an array, but in IE actually it's not. Today I investigated it, and it turned out, thatUInt8ArrayinmsCryptois an object.I found the following workaround, but I'm not sure is there any problems with it. If it's OK, I'll update Russian readme as well.