Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce bundlesize by moving from while to reduce #355

Merged
merged 2 commits into from Apr 18, 2022
Merged

reduce bundlesize by moving from while to reduce #355

merged 2 commits into from Apr 18, 2022

Conversation

artalar
Copy link
Contributor

@artalar artalar commented Apr 18, 2022

No description provided.

@ai
Copy link
Owner

ai commented Apr 18, 2022

😍😍😍

@artalar
Copy link
Contributor Author

artalar commented Apr 18, 2022

Just forcepushed another commit, thats all now :)

@ai ai merged commit f4e7325 into ai:main Apr 18, 2022
@ai
Copy link
Owner

ai commented Apr 18, 2022

Thanks. Released in 3.3.3.

@levrik
Copy link

levrik commented Apr 19, 2022

I'm wondering how the move from while to reduce affects performance. Method calls tend to be more expensive.

@ai
Copy link
Owner

ai commented Apr 19, 2022 •
edited

@levrik it is micro-optimization (especially in the case of browser version, Node.js version uses while).

Changes will not affect real results.

@ai
Copy link
Owner

ai commented Apr 19, 2022

@levrik I looked in benchmark (pnpm start to benchmark browser version) and didn’t find any changed before and after

@sync-by-unito sync-by-unito bot mentioned this pull request Apr 22, 2022
Closed
@vitalybaev vitalybaev mentioned this pull request May 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@artalar @ai @levrik