Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cannot find version of process #205

Closed
wants to merge 1 commit into from
Closed

Conversation

KSH-code
Copy link

@KSH-code KSH-code commented May 24, 2021

- The error occurs that is because process of execjs has been removed from rails/execjs@b0be19c
- to fix it, use shell script instead of execjs eval
- Fix ai#203
@KSH-code
Copy link
Author

KSH-code commented May 24, 2021

Ooops, it was solved by 3b3d244

is this pr not needed? @albb0920
If no, I will close.

@albb0920
Copy link
Collaborator

Thanks for the PR,
but I don't think dropping MiniRacer support is desirable at this point,
if people are using it without troubles, I'd like to avoid breaking changes.

So I've drop the version check as I mentioned in #203, sorry for the delay, I'll publish a new version shortly.
3b3d244

@albb0920 albb0920 closed this May 24, 2021
@KSH-code
Copy link
Author

Yup, I agree that.
Thanks for check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'version' of undefined
2 participants