Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed AttributeError when rendering an excgroup as a cause #34

Merged
merged 2 commits into from Oct 27, 2022
Merged

Conversation

agronholm
Copy link
Owner

@agronholm agronholm commented Oct 26, 2022

This adopts Python 3.10 TracebackException semantics. I also changed the various patched exception rendering functions to pass compact=True like py3.10 does. It has no effect on older Pythons.

There's some duplication in the initialization of the TE but I couldn't figure out any other sane way to fix this.

Fixes #33. Closes #35.

@coveralls
Copy link

coveralls commented Oct 26, 2022

@gschaffner
Copy link

gschaffner commented Oct 27, 2022

Looks good to me! I also haven't been able to think of a saner way to do this than duplicating the recursion unroller from stdlib.

I think this also fixes a related bug #35. Should a test be added for this?

@agronholm
Copy link
Owner Author

Done and done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants