Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type errors, add type tests #118

Merged
merged 12 commits into from Apr 18, 2024
Merged

Conversation

jakkdl
Copy link
Contributor

@jakkdl jakkdl commented Apr 15, 2024

The type test could be much more thorough, and given that I almost instantly found an unrelated error with suppress I suspect there could be more issues hidden. You should definitely add repro's of any other issues you have, and I might check them out and see if they have easy fixes.

@coveralls
Copy link

coveralls commented Apr 15, 2024

Pull Request Test Coverage Report for Build 8744686812

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 92.361%

Totals Coverage Status
Change from base Build 8744427096: 0.01%
Covered Lines: 532
Relevant Lines: 576

💛 - Coveralls

@agronholm
Copy link
Owner

One more thing: could you add a changelog note too? I'll merge when that's done.

@jakkdl
Copy link
Contributor Author

jakkdl commented Apr 18, 2024

This PR mostly just fixes #101, which didn't have a changelog entry and was unreleased, so I wrote an entry for that, and another entry for suppress() being fixed.

Although you probably want a note for #112 as well

@jakkdl
Copy link
Contributor Author

jakkdl commented Apr 18, 2024

I don't really understand #112, but more or less copied over the commit message to the changelog.

@jakkdl
Copy link
Contributor Author

jakkdl commented Apr 18, 2024

It looks like the 3.12 failure is unrelated to this PR

@agronholm
Copy link
Owner

It looks like the 3.12 failure is unrelated to this PR

Seems like this started within the last 24 hours. Perhaps caused by a Python update?

@jakkdl
Copy link
Contributor Author

jakkdl commented Apr 18, 2024

It looks like the 3.12 failure is unrelated to this PR

Seems like this started within the last 24 hours. Perhaps caused by a Python update?

Yeah it went from 3.12.2 (https://github.com/agronholm/exceptiongroup/actions/runs/8706318205/job/23878615916#step:3:12) to 3.12.3 (https://github.com/agronholm/exceptiongroup/actions/runs/8736236104/job/23970716558#step:3:12)

@agronholm agronholm merged commit 521f02f into agronholm:main Apr 18, 2024
15 checks passed
@agronholm
Copy link
Owner

Thanks!

@jakkdl jakkdl deleted the type_errors branch April 19, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type error with pyright when creating BaseExceptionGroup
3 participants