Fixed epoch date decoding being affected by the local time zone #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meejah
approved these changes
Feb 21, 2024
| @@ -1000,6 +1003,9 @@ PyInit__cbor2(void) | |||
|
|
|||
| #undef INTERN_STRING | |||
|
|
|||
| if (!_CBOR2_date_ordinal_offset && | |||
| !(_CBOR2_date_ordinal_offset = PyLong_FromLong(719163))) | |||
There was a problem hiding this comment.
Would be helpful (to me, who doesn't know CBOR expect as a user) to know what this magic number means.
There was a problem hiding this comment.
See the CBOR definition for semantic tag 100. 719163 is the number of days between the minimum supported CBOR date and the minimum supported Python date ordinal (which starts from January 1 of year 1).
|
Turns out the call was faulty and caused the C extension to fail compilation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #209.