fix: minor fix (jaegertracing#153)

* fix: minor fix * fix: remove _ prefix from params
agile-pm · Aug 5, 2019 · b1dc1a3 · b1dc1a3
1 parent 9e46dfd
commit b1dc1a3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/opentelemetry-core/src/trace/TracerDelegate.ts b/packages/opentelemetry-core/src/trace/TracerDelegate.ts
@@ -55,7 +55,7 @@ export class TracerDelegate implements types.Tracer {
     );
   }
 
-  startSpan(name: string, options?: types.SpanOptions | undefined): types.Span {
+  startSpan(name: string, options?: types.SpanOptions): types.Span {
     return this._currentTracer.startSpan.apply(
       this._currentTracer,
       // tslint:disable-next-line:no-any

diff --git a/packages/opentelemetry-core/test/trace/TracerDelegate.test.ts b/packages/opentelemetry-core/test/trace/TracerDelegate.test.ts
@@ -35,7 +35,7 @@ describe('TracerDelegate', () => {
     traceOptions: TraceOptions.UNSAMPLED,
   };
 
-  describe('#constructor(...)', () => {
+  describe('constructor', () => {
     it('should not crash with default constructor', () => {
       functions.forEach(fn => {
         const tracer = new TracerDelegate();
@@ -66,7 +66,7 @@ describe('TracerDelegate', () => {
       assert.deepStrictEqual(dummyTracer.spyCounter, 1);
     });
 
-    describe('#start/stop()', () => {
+    describe('.start/stop()', () => {
       it('should use the fallback tracer when stop is called', () => {
         const dummyTracerUser = new DummyTracer();
         const dummyTracerFallback = new DummyTracer();