fix spark-react test errors by adding react component proptype, see: f…

…acebook/prop-types#211
afebbraro · Oct 26, 2019 · 2ee2efe · 2ee2efe
1 parent 7136367
commit 2ee2efe
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 4 deletions.
diff --git a/react/src/base/links/SprkLink.js b/react/src/base/links/SprkLink.js
@@ -90,7 +90,11 @@ SprkLink.propTypes = {
   /** The href value for the link. */
   href: PropTypes.string,
   /** The element that will be rendered. */
-  element: PropTypes.oneOfType([PropTypes.string, PropTypes.func]),
+  element: PropTypes.oneOfType([
+    PropTypes.string,
+    PropTypes.func,
+    PropTypes.elementType
+  ]),
   /** The event that will fire when the element is clicked. */
   onClick: PropTypes.func,
 };

diff --git a/react/src/components/card/components/SprkCardTeaser/SprkCardTeaser.js b/react/src/components/card/components/SprkCardTeaser/SprkCardTeaser.js
@@ -207,15 +207,23 @@ SprkCardTeaser.propTypes = {
       additionalCtaIconClasses: PropTypes.string,
       ctaAnalytics: PropTypes.string,
       ctaIcon: PropTypes.string,
-      ctaLinkElement: PropTypes.oneOfType([PropTypes.string, PropTypes.func]),
+      ctaLinkElement: PropTypes.oneOfType([
+        PropTypes.string,
+        PropTypes.func,
+        PropTypes.elementType
+      ]),
       ctaVariant: PropTypes.oneOf(['link', 'button']),
       href: PropTypes.string,
       text: PropTypes.string,
     }),
     media: PropTypes.shape({
       additionalMediaIconClasses: PropTypes.string,
       href: PropTypes.string,
-      mediaLinkElement: PropTypes.oneOfType([PropTypes.string, PropTypes.func]),
+      mediaLinkElement: PropTypes.oneOfType([
+        PropTypes.string,
+        PropTypes.func,
+        PropTypes.elementType
+      ]),
       iconName: PropTypes.string,
       imgAlt: PropTypes.string,
       imgSrc: PropTypes.string,

diff --git a/react/src/components/masthead/SprkMasthead.js b/react/src/components/masthead/SprkMasthead.js
@@ -323,7 +323,11 @@ SprkMasthead.propTypes = {
   /** The href to render for the logo link. */
   logoLink: PropTypes.string,
   /** The element link element to render for the logo. */
-  logoLinkElement: PropTypes.oneOfType([PropTypes.string, PropTypes.func]),
+  logoLinkElement: PropTypes.oneOfType([
+    PropTypes.string,
+    PropTypes.func,
+    PropTypes.elementType
+  ]),
   /** Expects a component to render the nav link. */
   navLink: PropTypes.node,
 };