-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logdir fixes #4344
base: master
Are you sure you want to change the base?
Logdir fixes #4344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of issues as we already discussed:
- foreground doesn't handle CRTL+C which is a must in interactive usage and for orchestrators
- the default log level should be INFO instead of DEBUG as it was for console output
Turns out that Erlang actually handles SIGTERM these days as equivalent to running init:stop(), so plain @dincho Do you have some reference you can point me to that states clearly what is expected with regard to SIGINT in Docker? |
I don't think that this is docker specific, this is general UNIX/POSIX process expectations. When you hit CRTL+C you expect the process to stop "immediately" or you (at least me) never run that crap again. |
I guess the process doesn't stop on time then and get's killed: https://docs.docker.com/reference/cli/docker/container/stop/#description |
Ensures that log files and directories are not created when running in foreground mode.
Closes #3860