Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed timer initialization in aedevmode_emitter:init #4325

Closed
wants to merge 1 commit into from

Conversation

ThomasArts
Copy link
Contributor

replaces PR #4303 to get permission to run CI

@uwiger
Copy link
Member

uwiger commented Apr 10, 2024

Is this necessarily what one wants, though?

My assumption has been that one would often want to manually start/stop block production.
Perhaps an option to control auto-start?

@ThomasArts
Copy link
Contributor Author

Is this necessarily what one wants, though?

My assumption has been that one would often want to manually start/stop block production. Perhaps an option to control auto-start?

Indeed. I have questions here:

  1. to @uwiger where is the specification on how this should work? If you have auto-emit true and a microblock interval set, how then do you guarantee that you keep that interval?
  2. If you use auto-emit false then @davidyuk why do you expect micro blocks to be produced at all unless you call mine_until_txs_on_chain?

@ThomasArts
Copy link
Contributor Author

This is not the right solution to the problem, we need to revisit the emitter to support additional use cases and document better what it does today.

@ThomasArts ThomasArts closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants