Gh 4133 contract code endpoint and HTTP refactoring #4156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwiger
reviewed
Jul 6, 2023
| @@ -0,0 +1,7 @@ | |||
| @title AE API: The tiny JSON encoder/decoder | |||
|
|
||
| blockchain_name() -> | ||
| <<"aeternity">>. %% TODO: check hardcoding | ||
| %% TODO: Check whether this should be hardcoded or retrieved from settings (?) | ||
| <<"aeternity">>. |
There was a problem hiding this comment.
What is the difference between blockchain_name() and network_id()?
Comment on lines
+154
to
+156
| case aec_chain:top_block() of | ||
| undefined -> error; | ||
| Block -> {ok, aec_blocks:height(Block)} |
There was a problem hiding this comment.
Suggested change
| case aec_chain:top_block() of | |
| undefined -> error; | |
| Block -> {ok, aec_blocks:height(Block)} | |
| case aec_chain:dirty_top_header() of | |
| undefined -> error; | |
| Hdr -> {ok, aec_headers:height(Block)} |
There was a problem hiding this comment.
aec_chain:top_block() also fetches all included transactions.
Comment on lines
+176
to
+179
| case aec_chain:top_block() of | ||
| undefined -> error; | ||
| Block -> {ok, aec_blocks:to_header(Block)} | ||
| end. |
There was a problem hiding this comment.
Suggested change
| case aec_chain:top_block() of | |
| undefined -> error; | |
| Block -> {ok, aec_blocks:to_header(Block)} | |
| end. | |
| case aec_chain:top_header() of | |
| undefined -> error; | |
| Hdr -> {ok, Hdr} | |
| end. |
Comment on lines
+205
to
+209
| top_key_block_header() -> | ||
| case aec_chain:top_key_block() of | ||
| {ok, Block} -> {ok, aec_blocks:to_header(Block)}; | ||
| error -> error | ||
| end. |
There was a problem hiding this comment.
Suggested change
| top_key_block_header() -> | |
| case aec_chain:top_key_block() of | |
| {ok, Block} -> {ok, aec_blocks:to_header(Block)}; | |
| error -> error | |
| end. | |
| top_key_block_header() -> | |
| aec_db:ensure_activity(async_dirty, fun top_key_block_header_/0). | |
| top_key_block_header_() -> | |
| case aec_chain:top_header() of | |
| undefined -> error; | |
| Header -> | |
| case aec_headers:type(Header) of | |
| micro -> | |
| Hash = aec_headers:prev_key_hash(Header), | |
| {ok, _} = aec_chain:get_header(Hash); | |
| key -> | |
| {ok, Header} | |
| end | |
| end. |
Comment on lines
+259
to
+263
| key_block_header_at_height(Height) when is_integer(Height) -> | ||
| case key_block_at_height(Height) of | ||
| {ok, Block} -> {ok, aec_blocks:to_header(Block)}; | ||
| Error -> Error | ||
| end. |
There was a problem hiding this comment.
Suggested change
| key_block_header_at_height(Height) when is_integer(Height) -> | |
| case key_block_at_height(Height) of | |
| {ok, Block} -> {ok, aec_blocks:to_header(Block)}; | |
| Error -> Error | |
| end. | |
| key_block_header_at_height(Height) when is_integer(Height) -> | |
| case aec_chain:get_key_header_by_height(Height) of | |
| {ok, _} = Ok -> Ok; | |
| {error, _} = Error -> Error | |
| end. |
| PrevBlockHash = aec_blocks:prev_key_hash(Block), | ||
| aec_chain:get_block(PrevBlockHash); | ||
| true -> | ||
| {ok, Block} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.