Improve tests to expose server mode of SC FSM #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radrow
approved these changes
Aug 31, 2020
gorbak25
reviewed
Sep 3, 2020
| ct:log("Config1 = ~p", [Config1]), | ||
| ReestablishOptions = sc_ws_leave_(Config1), | ||
| Config2 = reconnect_client_(ReestablishOptions, initiator, | ||
| [{reconnect_scenario, reestablish} | Config1]), |
There was a problem hiding this comment.
Odd formatting compared to other places in the codebase.
Suggested change
| [{reconnect_scenario, reestablish} | Config1]), | |
| [{reconnect_scenario, reestablish}|Config1]), |
| Opts = | ||
| lists:foldl( | ||
| fun({keep_running, Bool}, Accum) when is_boolean(Bool) -> | ||
| Accum#{keep_running => true}; |
There was a problem hiding this comment.
Might be confusing for future users who might call custom_responder_opts([{keep_running, false}])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3069
Ulf's comment was right and this indeed is already present. I added some tests to validate it.
This PR had been produced with the support of the Aeternity Foundation. You can read about this in the forum.