Handle client disconnect during signing (as client abort) #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velzevur
previously approved these changes
May 1, 2020
|
Rebase and reissue for review |
uwiger
force-pushed
the
gh-3246-resend-sig-requests
branch
from
f08e1e4
to
6b053d0
Compare
velzevur
previously approved these changes
Sep 3, 2021
uwiger
force-pushed
the
gh-3246-resend-sig-requests
branch
from
6b053d0
to
fb8e2c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #3246
Locally, the test suite fails on
force_progress_triggers_slash(). It's not clear to me why.