Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Maven to 3.8.5 #3479

Merged
merged 1 commit into from Mar 21, 2022
Merged

Update Maven to 3.8.5 #3479

merged 1 commit into from Mar 21, 2022

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Mar 21, 2022

Manually update Maven to 3.8.5, the latest and recommended version for
all users. Default apt-get install version 3.6.3 doesn't support JDK 17.

Cleanup leftover dead functions
Remove the ifcondition for alpine as no os is supported other than
ubuntu
Update mode=java properties to support property defined by with
key=value

Fix #3390
Fix #3382

Signed-off-by: Sophia Guo sophia.gwf@gmail.com

Manually update Maven to 3.8.5, the latest and recommended version for
all users. Default apt-get install version 3.6.3 doesn't support JDK 17.

Cleanup leftover dead functions
Remove the ifcondition for alpine as no os is supported other than
ubuntu
Update mode=java properties to support property defined by with
key=value

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
@sophia-guo
Copy link
Contributor Author

Jacoco grinder https://ci.adoptopenjdk.net/view/work-in-progress/job/grinder_sandbox_new/546/console
Grinder shows jacoco run with jdk17 and there is new test failures, will open a separate issue.

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sophia-guo !

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit f24a025 into adoptium:master Mar 21, 2022
@sophia-guo sophia-guo deleted the maven branch May 13, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

external test jacoco_test failed with jdk17 (passed with jdk11) quarkus_quickstarts_test_0 failed with jdk17
3 participants