Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external test jacoco_test failed with jdk17 (passed with jdk11) #3390

Closed
sophia-guo opened this issue Mar 1, 2022 · 10 comments · Fixed by #3479
Closed

external test jacoco_test failed with jdk17 (passed with jdk11) #3390

sophia-guo opened this issue Mar 1, 2022 · 10 comments · Fixed by #3479
Assignees
Labels

Comments

@sophia-guo
Copy link
Contributor

sophia-guo commented Mar 1, 2022

external test jacoco_test failed with jdk17 (passed with jdk11)
jdk11: https://ci.adoptopenjdk.net/view/work-in-progress/job/grinder_sandbox_new/456/ passed
jdk17: https://ci.adoptopenjdk.net/view/work-in-progress/job/grinder_sandbox_new/449/console

17:54:39  /jacoco/org.jacoco.build
17:54:39  Compile and run jacoco tests
17:54:39  Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8 -Djava.security.egd=file:/dev/./urandom
17:54:40  [�[1;31mERROR�[m] Error executing Maven.
17:54:40  [�[1;31mERROR�[m] java.lang.IllegalStateException: Unable to load cache item
17:54:40  [�[1;31mERROR�[m] Caused by: Unable to load cache item
17:54:40  [�[1;31mERROR�[m] Caused by: Could not initialize class com.google.inject.internal.cglib.core.$MethodWrapper
17:54:40  Build jacoco completed
17:54:40  Test results copied
17:54:41  
17:54:41  jacoco_test_0_FAILED
@sophia-guo
Copy link
Contributor Author

We currently are not using the latest stable build which appears to be https://github.com/jacoco/jacoco/releases/tag/v0.8.7. We likely should switch to using it by updating tag_version="v0.8.7" to the jacoco/test.properties file.

We may still see the issue being reported, but at least we are pulling a stable build (otherwise we are just pulling from master/main branch).

The comment of https://github.com/jacoco/jacoco/releases/tag/v0.8.7
JaCoCo now officially supports Java 15 and 16 (GitHub jacoco/jacoco#1094, jacoco/jacoco#1097, jacoco/jacoco#1176).
Experimental support for Java 17 class files (GitHub jacoco/jacoco#1132).

The failure with jdk17 might be expected.

@yinggzz
Copy link
Contributor

yinggzz commented Mar 2, 2022

I would like to work on this issue

yinggzz added a commit to yinggzz/aqa-tests that referenced this issue Mar 2, 2022
Fixes: adoptium#3390

Signed-off-by: Ying Zhou
@yinggzz
Copy link
Contributor

yinggzz commented Mar 2, 2022

external test jacoco_test with jdk17 after updating tag_version = "v0.8.7": https://ci.adoptopenjdk.net/job/Grinder/3766/console
@sophia-guo Hi Sophia, can I get some clarification on what next step I should take?

@sophia-guo
Copy link
Contributor Author

sophia-guo commented Mar 7, 2022

Test passed with jdk11 and failed with jdk17. So might not be the test environment setting issue. The failure is similar to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=980467, which suggests the issue is with maven and jdk17. The specific maven version doesn't work with jdk17. I can see same failure with #3382 and believe there are other tests got the same failures. Could you please print the maven version by command mvn -v ? Thanks.

@sophia-guo
Copy link
Contributor Author

@yinggzz please see the comment #3390 (comment)

@yinggzz
Copy link
Contributor

yinggzz commented Mar 14, 2022

Grinder link: https://ci.adoptopenjdk.net/job/Grinder/3842/ (passed?)

maven version 3.6.3

output of command mvn-v:

11:58:22  Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8 -Djava.security.egd=file:/dev/./urandom
11:58:22  �[1mApache Maven 3.6.3�[m
11:58:22  Maven home: /usr/share/maven
11:58:22  Java version: 17.0.3-beta, vendor: Eclipse Adoptium, runtime: /opt/java/openjdk
11:58:22  Default locale: en_US, platform encoding: UTF8
11:58:22  OS name: "linux", version: "4.4.0-204-generic", arch: "amd64", family: "unix"

@sophia-guo
Copy link
Contributor Author

It passed because your change will only run mvn -v command, no tests will run. If your branch 3390 is used to commit some tag update, you will need to reverse that change.

@smlambert
Copy link
Contributor

This has found an interesting defect, given that there were errors and it still shows as passed.

11:58:23  The directory in the external.sh is jacoco
11:58:23  Error: No such container: jacoco-test

@sophia-guo
Copy link
Contributor Author

same error happened to netty.

@sophia-guo
Copy link
Contributor Author

re #3390 (comment)

The error message is expected, similar to the error message when doing the image clean at the build step. We explicitly remove the container no matter it exist or not, which should not affect the build status.

11:57:24  clean_image:
11:57:24       [echo] Executing external.sh --clean --dir jacoco --tag nightly --version 17 --impl hotspot 
11:57:24       [exec] The test here is jacoco
11:57:24       [exec] The directory in the external.sh is jacoco
11:57:24       [exec] Error: No such container: jacoco-test
11:57:24       [exec] Result: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants