Fix MIME type checks #231
Fix MIME type checks #231
Conversation
Using a regular expression to check MIME types was problematic and unnecessary. Problematic because it wasn't escaping characters, so for example, `image/svg+xml` would not match because the `+` was interpreted as a 1-or-more modifier on the `g`. Unnecessary because the accept attribute only accepts a very limited set of clearly enumerated type wildcards (see https://html.spec.whatwg.org/multipage/input.html#file-upload-state-(type=file)). So, match more tightly and correctly doing string comparisons, and add some unit tests for this (and to verify case-insensitivity, which was missing for mime types).
|
Hmm Ember Beta and Ember Canary are failing builds unrelated to this PR. If you could also help out with getting these tests passing that would be awesome. If not I will hopefully get to it this week or next week :) |
|
I think I should be able to get to that in later today. |
|
Awesome @bendemboski thanks! |
|
Okay, investigated a bit, and the failure is because When that gets released I'll poke this branch to get it rerun the build and ping you once it's ready and passing. |
|
Awesome detective work! Let's wait for that and once tests are passing let's get this stuff merged! |
|
@Alonski build passing now! |
Using a regular expression to check MIME types was problematic and unnecessary. Problematic because it wasn't escaping characters, so for example,
image/svg+xmlwould not match because the+was interpreted as a 1-or-more modifier on theg. Unnecessary because the accept attribute only accepts a very limited set of clearly enumerated type wildcards (see https://html.spec.whatwg.org/multipage/input.html#file-upload-state-(type=file)).So, match more tightly and correctly doing string comparisons, and add some unit tests for this (and to verify case-insensitivity, which was missing for mime types).