Breaking change - Switch ORM naming strategy to CamelCase #986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a breaking change as it switches the naming strategy of ORM to camelcase. If this PR gets merged, this is how everything will be named.
camelCase
. Because, that is how we name properties and variables in JS.snake_case
(no change here).snake_case
(no change here).model.toJSON()
will becamelCase
. This is the breaking changeWhy the change
The internal discussion was initiated by @RomainLanz to use camelCase for the serialized output as well. Models are usually (but not limited to) serialized when sending a JSON response for an HTTP API and a lot of the HTTP API consumers are frontend JavaScript clients which prefer
camelCase
oversnake_case
and hence they have to rename all these properties.I believe Romain might have received this feedback from various channels and therefore he might be able to share more insights.