feat(errors): use new way to define exceptions #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some tests seems to be impacted by the change |
RomainLanz
force-pushed
the
feat/errors
branch
from
d04b09f
to
ba1adf9
Compare
RomainLanz
commented
Oct 6, 2023
| assert.equal( | ||
| migrator1.error!.message, | ||
| 'Cannot perform rollback. Schema file {database/migrations/accounts_v11} is missing' |
There was a problem hiding this comment.
Is there any reason the file path was surrounded by {}?
That would be a breaking change if another tool uses it to extract the path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! 馃憢馃徎
This PR uses the new way of defining exceptions that we are using for V6 packages.
I also took the opportunity to fix some typos in related files.
I believe we can migrate more exceptions thrown without any code to isolate them to this new system.
What do you think?