refactor: change sqlite dropAllTables implementation #1001
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Type of change
π Description
Fix #999
I have updated the implementation of
dropAllTables
forbetter-sqlite3
andsqlite
:The implementation was causing problems for
better-sqlite3
as explained in the linked issue. i also preferred to modify the implementation forsqlite
by modifying theBaseSqlite
class so that we don't have two different methods to maintainThe problem is linked to the
unsafeMode
explained here: https://github.com/WiseLibs/better-sqlite3/blob/master/docs/unsafe.md and therefore to our use ofPRAGMA writable_schema
.As a result, I've decided to drop all tables with multiples queries rather than modifying
sqlite_master
directly. this way, we don't need to activate the unsafe mode. the method is probably slower, but imo it doesn't matter at allindexes and triggers are automatically deleted if linked to a deleted table